Code review comment for lp:~elementary-apps/switchboard/cleanup

Revision history for this message
Julián Unrrein (junrrein) wrote :

Re-indent diff lines 150, 153, 163-164, 391, they are part of foreach blocks.

You can close lines 163-164 in curly braces for clarity.

Diff line 225: Move the warning to its own line.

Diff line 373: Space after get_file_type.

Diff line 475: Space after search_box_activated.

I see you also fixed stuff I didn't catch, nice!

review: Needs Fixing

« Back to merge proposal