Code review comment for lp:~elementary-apps/pantheon-terminal/csd-titlebar

Fair enough, but I don't like the way the default styling causes the title
to collide with the left hand edge when the title is longer than the space
allows. I prefer at least a little padding. Ellipsizing the start also
matches the ellipsizing on the tab labels. You can still use a custom
title while still removing the header-bar class.

On 12 April 2014 15:35, Daniel Fore <email address hidden> wrote:

> I don't want the app to control the padding though, I want it controlled
> in the theme. Right now GtkHeaderBar already carries the two classes
> "titlebar" and "headerbar". They have their subtle differences in the theme
> that extend beyond just the padding (for example, the titlebar doesn't need
> such a dramatic gradient since it is so much shorter). All this does is
> remove the "headerbar" class which overrides/extends the theming set in
> .titlebar
> --
>
> https://code.launchpad.net/~elementary-apps/pantheon-terminal/csd-titlebar/+merge/215373
> Your team elementary Apps team is requested to review the proposed merge
> of lp:~elementary-apps/pantheon-terminal/csd-titlebar into
> lp:pantheon-terminal.
>