Merge lp:~elementary-apps/pantheon-mail/no-geary-ui into lp:~elementary-apps/pantheon-mail/trunk

Proposed by Danielle Foré
Status: Merged
Approved by: Danielle Foré
Approved revision: 1949
Merged at revision: 1949
Proposed branch: lp:~elementary-apps/pantheon-mail/no-geary-ui
Merge into: lp:~elementary-apps/pantheon-mail/trunk
Diff against target: 144 lines (+15/-15)
7 files modified
data/ui/account_spinner.ui (+1/-1)
data/ui/composer.ui (+1/-1)
data/ui/upgrade_dialog.ui (+1/-1)
src/client/accounts/add-edit-page.vala (+1/-1)
src/client/application/geary-controller.vala (+6/-6)
src/client/dialogs/certificate-warning-dialog.vala (+4/-4)
src/client/dialogs/password-dialog.vala (+1/-1)
To merge this branch: bzr merge lp:~elementary-apps/pantheon-mail/no-geary-ui
Reviewer Review Type Date Requested Status
Ralph Plawetzki (community) Approve
Review via email: mp+284333@code.launchpad.net

Commit message

Replace instances of Geary in .ui files with Mail

To post a comment you must log in.
1949. By Ralph Plawetzki

replace instances of Geary with Mail

Revision history for this message
Ralph Plawetzki (purejava) wrote :

Looks good.

review: Approve
Revision history for this message
Ralph Plawetzki (purejava) wrote :

> Looks good.

Forget to say that I changed some more strings as discussed on slack before.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/ui/account_spinner.ui'
--- data/ui/account_spinner.ui 2015-12-14 17:36:36 +0000
+++ data/ui/account_spinner.ui 2016-01-29 06:24:26 +0000
@@ -38,7 +38,7 @@
38 <object class="GtkLabel" id="label1">38 <object class="GtkLabel" id="label1">
39 <property name="visible">True</property>39 <property name="visible">True</property>
40 <property name="can_focus">False</property>40 <property name="can_focus">False</property>
41 <property name="label" translatable="yes">Please wait while Geary validates your account.</property>41 <property name="label" translatable="yes">Please wait while Mail validates your account.</property>
42 </object>42 </object>
43 <packing>43 <packing>
44 <property name="expand">False</property>44 <property name="expand">False</property>
4545
=== modified file 'data/ui/composer.ui'
--- data/ui/composer.ui 2015-12-14 17:36:36 +0000
+++ data/ui/composer.ui 2016-01-29 06:24:26 +0000
@@ -437,7 +437,7 @@
437 <object class="GtkLabel" id="from label">437 <object class="GtkLabel" id="from label">
438 <property name="visible">True</property>438 <property name="visible">True</property>
439 <property name="can_focus">False</property>439 <property name="can_focus">False</property>
440 <property name="label" translatable="yes" comments="Geary account mail will be sent from">From</property>440 <property name="label" translatable="yes" comments="Account mail will be sent from">From</property>
441 <property name="justify">right</property>441 <property name="justify">right</property>
442 <property name="mnemonic_widget">to</property>442 <property name="mnemonic_widget">to</property>
443 <property name="xalign">1</property>443 <property name="xalign">1</property>
444444
=== modified file 'data/ui/upgrade_dialog.ui'
--- data/ui/upgrade_dialog.ui 2015-12-14 17:36:36 +0000
+++ data/ui/upgrade_dialog.ui 2016-01-29 06:24:26 +0000
@@ -57,7 +57,7 @@
57 <object class="GtkLabel" id="text_label">57 <object class="GtkLabel" id="text_label">
58 <property name="visible">True</property>58 <property name="visible">True</property>
59 <property name="can_focus">False</property>59 <property name="can_focus">False</property>
60 <property name="label" translatable="yes">Geary update in progress…</property>60 <property name="label" translatable="yes">Mail update in progress…</property>
61 </object>61 </object>
62 <packing>62 <packing>
63 <property name="left_attach">1</property>63 <property name="left_attach">1</property>
6464
=== modified file 'src/client/accounts/add-edit-page.vala'
--- src/client/accounts/add-edit-page.vala 2015-12-14 17:46:52 +0000
+++ src/client/accounts/add-edit-page.vala 2016-01-29 06:24:26 +0000
@@ -768,7 +768,7 @@
768 error_string += _(" &#8226; Invalid account nickname.\n");768 error_string += _(" &#8226; Invalid account nickname.\n");
769 769
770 if (last_validation_result.is_all_set(Geary.Engine.ValidationResult.EMAIL_EXISTS))770 if (last_validation_result.is_all_set(Geary.Engine.ValidationResult.EMAIL_EXISTS))
771 error_string += _(" &#8226; Email address already added to Geary.\n");771 error_string += _(" &#8226; Email address already added to Mail.\n");
772 772
773 if (get_service_provider() == Geary.ServiceProvider.OTHER) {773 if (get_service_provider() == Geary.ServiceProvider.OTHER) {
774 if (last_validation_result.is_all_set(Geary.Engine.ValidationResult.IMAP_CONNECTION_FAILED))774 if (last_validation_result.is_all_set(Geary.Engine.ValidationResult.IMAP_CONNECTION_FAILED))
775775
=== modified file 'src/client/application/geary-controller.vala'
--- src/client/application/geary-controller.vala 2016-01-28 17:48:53 +0000
+++ src/client/application/geary-controller.vala 2016-01-29 06:24:26 +0000
@@ -1049,12 +1049,12 @@
1049 switch (message) {1049 switch (message) {
1050 case StatusBar.Message.OUTBOX_SEND_FAILURE:1050 case StatusBar.Message.OUTBOX_SEND_FAILURE:
1051 libnotify.set_error_notification(_("Error sending email"),1051 libnotify.set_error_notification(_("Error sending email"),
1052 _("Geary encountered an error sending an email. If the problem persists, please manually delete the email from your Outbox folder."));1052 _("Mail encountered an error sending an email. If the problem persists, please manually delete the email from your Outbox folder."));
1053 break;1053 break;
10541054
1055 case StatusBar.Message.OUTBOX_SAVE_SENT_MAIL_FAILED:1055 case StatusBar.Message.OUTBOX_SAVE_SENT_MAIL_FAILED:
1056 libnotify.set_error_notification(_("Error saving sent mail"),1056 libnotify.set_error_notification(_("Error saving sent mail"),
1057 _("Geary encountered an error saving a sent message to Sent Mail. The message will stay in your Outbox folder until you delete it."));1057 _("Mail encountered an error saving a sent message to Sent Mail. The message will stay in your Outbox folder until you delete it."));
1058 break;1058 break;
10591059
1060 default:1060 default:
@@ -1136,7 +1136,7 @@
1136 // have provisions for that.1136 // have provisions for that.
1137 AlertDialog dialog = new QuestionDialog(main_window,1137 AlertDialog dialog = new QuestionDialog(main_window,
1138 _("Unable to open the database for %s").printf(account.information.email),1138 _("Unable to open the database for %s").printf(account.information.email),
1139 _("There was an error opening the local mail database for this account. This is possibly due to corruption of the database file in this directory:\n\n%s\n\nGeary can rebuild the database and re-synchronize with the server or exit.\n\nRebuilding the database will destroy all local email and its attachments. <b>The mail on the your server will not be affected.</b>")1139 _("There was an error opening the local mail database for this account. This is possibly due to corruption of the database file in this directory:\n\n%s\n\nMail can rebuild the database and re-synchronize with the server or exit.\n\nRebuilding the database will destroy all local email and its attachments. <b>The mail on the your server will not be affected.</b>")
1140 .printf(account.information.settings_dir.get_path()),1140 .printf(account.information.settings_dir.get_path()),
1141 _("_Rebuild"), _("E_xit"));1141 _("_Rebuild"), _("E_xit"));
1142 dialog.use_secondary_markup(true);1142 dialog.use_secondary_markup(true);
@@ -1181,7 +1181,7 @@
1181 private async void account_database_version_async(Geary.Account account) {1181 private async void account_database_version_async(Geary.Account account) {
1182 ErrorDialog dialog = new ErrorDialog(main_window,1182 ErrorDialog dialog = new ErrorDialog(main_window,
1183 _("Unable to open local mailbox for %s").printf(account.information.email),1183 _("Unable to open local mailbox for %s").printf(account.information.email),
1184 _("The version number of the local mail database is formatted for a newer version of Geary. Unfortunately, the database cannot be \"rolled back\" to work with this version of Geary.\n\nPlease install the latest version of Geary and try again."));1184 _("The version number of the local mail database is formatted for a newer version of Mail. Unfortunately, the database cannot be \"rolled back\" to work with this version of Mail.\n\nPlease install the latest version of Mail and try again."));
1185 dialog.run();1185 dialog.run();
11861186
1187 GearyApplication.instance.exit(1);1187 GearyApplication.instance.exit(1);
@@ -1192,7 +1192,7 @@
1192 // Geary today with an account in unopened state, so have to exit1192 // Geary today with an account in unopened state, so have to exit
1193 ErrorDialog dialog = new ErrorDialog(main_window,1193 ErrorDialog dialog = new ErrorDialog(main_window,
1194 _("Unable to open local mailbox for %s").printf(account.information.email),1194 _("Unable to open local mailbox for %s").printf(account.information.email),
1195 _("There was an error opening the local account. This is probably due to connectivity issues.\n\nPlease check your network connection and restart Geary."));1195 _("There was an error opening the local account. This is probably due to connectivity issues.\n\nPlease check your network connection and restart Mail."));
1196 dialog.run();1196 dialog.run();
11971197
1198 GearyApplication.instance.exit(1);1198 GearyApplication.instance.exit(1);
@@ -2399,7 +2399,7 @@
23992399
2400 ConfirmationDialog dialog = new ConfirmationDialog(main_window,2400 ConfirmationDialog dialog = new ConfirmationDialog(main_window,
2401 _("Empty all email from your %s folder?").printf(special_folder_type.get_display_name()),2401 _("Empty all email from your %s folder?").printf(special_folder_type.get_display_name()),
2402 _("This removes the email from Geary and your email server.")2402 _("This removes the email from Mail and your email server.")
2403 + " <b>" + _("This cannot be undone.") + "</b>",2403 + " <b>" + _("This cannot be undone.") + "</b>",
2404 _("Empty %s").printf(special_folder_type.get_display_name()));2404 _("Empty %s").printf(special_folder_type.get_display_name()));
2405 dialog.use_secondary_markup(true);2405 dialog.use_secondary_markup(true);
24062406
=== modified file 'src/client/dialogs/certificate-warning-dialog.vala'
--- src/client/dialogs/certificate-warning-dialog.vala 2015-12-14 17:46:52 +0000
+++ src/client/dialogs/certificate-warning-dialog.vala 2016-01-29 06:24:26 +0000
@@ -49,16 +49,16 @@
49 // could be a new or existing account49 // could be a new or existing account
50 dont_trust_label.label =50 dont_trust_label.label =
51 "<b>"51 "<b>"
52 + _("Selecting \"Don't Trust This Server\" will cause Geary not to access this server.")52 + _("Selecting \"Don't Trust This Server\" will cause Mail not to access this server.")
53 + "</b> "53 + "</b> "
54 + _("Geary will not add or update this email account.");54 + _("Mail will not add or update this email account.");
55 } else {55 } else {
56 // a registered account56 // a registered account
57 dont_trust_label.label =57 dont_trust_label.label =
58 "<b>"58 "<b>"
59 + _("Selecting \"Don't Trust This Server\" will cause Geary to stop accessing this account.")59 + _("Selecting \"Don't Trust This Server\" will cause Mail to stop accessing this account.")
60 + "</b> "60 + "</b> "
61 + _("Geary will exit if you have no other open email accounts.");61 + _("Mail will exit if you have no other open email accounts.");
62 }62 }
63 dont_trust_label.use_markup = true;63 dont_trust_label.use_markup = true;
64 64
6565
=== modified file 'src/client/dialogs/password-dialog.vala'
--- src/client/dialogs/password-dialog.vala 2015-12-14 17:46:52 +0000
+++ src/client/dialogs/password-dialog.vala 2016-01-29 06:24:26 +0000
@@ -13,7 +13,7 @@
13 // strings, and Glade doesn't support the "larger" size attribute. See this bug report for13 // strings, and Glade doesn't support the "larger" size attribute. See this bug report for
14 // details: https://bugzilla.gnome.org/show_bug.cgi?id=67900614 // details: https://bugzilla.gnome.org/show_bug.cgi?id=679006
15 private const string PRIMARY_TEXT_MARKUP = "<span weight=\"bold\" size=\"larger\">%s</span>";15 private const string PRIMARY_TEXT_MARKUP = "<span weight=\"bold\" size=\"larger\">%s</span>";
16 private const string PRIMARY_TEXT_FIRST_TRY = _("Geary requires your email password to continue");16 private const string PRIMARY_TEXT_FIRST_TRY = _("Mail requires your email password to continue");
17 17
18 private Gtk.Dialog dialog;18 private Gtk.Dialog dialog;
19 private Gtk.Entry entry_password;19 private Gtk.Entry entry_password;

Subscribers

People subscribed via source and target branches