Code review comment for lp:~elementary-apps/pantheon-greeter/optional-gl

CMake stuff works but it fails to compile:

codygarver@cubie:~/greeter/build$ cmake .. -DCMAKE_INSTALL_PREFIX=/usr
-- The C compiler identification is GNU
-- The CXX compiler identification is GNU
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- checking for modules 'granite;liblightdm-gobject-1>=1.2.1;gdk-x11-3.0;clutter-gtk-1.0;indicator3-0.4;gdk-pixbuf-2.0;gl'
-- found granite, version 0.2.2
-- found liblightdm-gobject-1, version 1.2.1
-- found gdk-x11-3.0, version 3.4.1
-- found clutter-gtk-1.0, version 1.4.2
-- found indicator3-0.4, version 0.5.0
-- found gdk-pixbuf-2.0, version 2.26.1
-- found gl, version 8.0.4
-- Found Vala: /usr/bin/valac
-- checking for a minimum Vala version of 0.16.1
-- found Vala, version 0.16.1
-- GSettings schemas will be installed locally.
-- GSettings shemas will be compiled.
-- GSettings schemas will be installed into /usr/share/glib-2.0/schemas/
-- Configuring done
-- Generating done
-- Build files have been written to: /home/codygarver/greeter/build'

codygarver@cubie:~/greeter/build$ make
[ 11%] Generating src/Utilities.c, src/Wallpaper.c, src/ShadowedLabel.c, src/Indicators.c, src/LoginBox.c, src/PantheonGreeter.c, build/src/config.c
Scanning dependencies of target pantheon-greeter
[ 22%] Building C object CMakeFiles/pantheon-greeter.dir/src/Utilities.c.o
/home/codygarver/greeter/build/src/Utilities.c: In function ‘_cogl_material_ref0’:
/home/codygarver/greeter/build/src/Utilities.c:226:2: warning: ‘cogl_material_ref’ is deprecated (declared at /usr/include/cogl/cogl/cogl-material-compat.h:175) [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Utilities.c: In function ‘mirror_effect_real_paint_target’:
/home/codygarver/greeter/build/src/Utilities.c:304:9: warning: assignment from incompatible pointer type [enabled by default]
/home/codygarver/greeter/build/src/Utilities.c:363:2: warning: ‘clutter_actor_get_depth’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-actor.h:91): Use 'clutter_actor_get_z_position' instead [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Utilities.c:379:2: warning: ‘clutter_actor_get_depth’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-actor.h:91): Use 'clutter_actor_get_z_position' instead [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Utilities.c:396:2: warning: ‘clutter_actor_get_depth’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-actor.h:91): Use 'clutter_actor_get_z_position' instead [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Utilities.c:411:2: warning: ‘clutter_actor_get_depth’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-actor.h:91): Use 'clutter_actor_get_z_position' instead [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Utilities.c:420:2: warning: ‘cogl_material_unref’ is deprecated (declared at /usr/include/cogl/cogl/cogl-material-compat.h:188) [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Utilities.c: In function ‘__lambda5_’:
/home/codygarver/greeter/build/src/Utilities.c:893:9: warning: assignment from incompatible pointer type [enabled by default]
/home/codygarver/greeter/build/src/Utilities.c: In function ‘__lambda4_’:
/home/codygarver/greeter/build/src/Utilities.c:907:2: warning: ‘clutter_actor_animate’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-animation.h:162) [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Utilities.c: In function ‘pop_over_construct’:
/home/codygarver/greeter/build/src/Utilities.c:969:2: warning: ‘clutter_actor_animate’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-animation.h:162) [-Wdeprecated-declarations]
[ 33%] Building C object CMakeFiles/pantheon-greeter.dir/src/Wallpaper.c.o
In file included from /usr/include/GL/gl.h:2085:0,
                 from /home/codygarver/greeter/build/src/Wallpaper.c:14:
/usr/include/GL/glext.h:5327:19: error: conflicting types for ‘GLintptr’
/usr/include/GLES2/gl2.h:37:26: note: previous declaration of ‘GLintptr’ was here
/usr/include/GL/glext.h:5328:19: error: conflicting types for ‘GLsizeiptr’
/usr/include/GLES2/gl2.h:38:26: note: previous declaration of ‘GLsizeiptr’ was here
/home/codygarver/greeter/build/src/Wallpaper.c: In function ‘wallpaper_set_wallpaper’:
/home/codygarver/greeter/build/src/Wallpaper.c:352:2: warning: ‘clutter_actor_detach_animation’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-animation.h:202) [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Wallpaper.c:354:2: warning: ‘clutter_actor_detach_animation’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-animation.h:202) [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Wallpaper.c: In function ‘wallpaper_load_wallpaper_co’:
/home/codygarver/greeter/build/src/Wallpaper.c:591:3: warning: ‘clutter_actor_animate’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-animation.h:162) [-Wdeprecated-declarations]
/home/codygarver/greeter/build/src/Wallpaper.c: In function ‘wallpaper_resize’:
/home/codygarver/greeter/build/src/Wallpaper.c:949:2: warning: ‘clutter_texture_get_base_size’ is deprecated (declared at /usr/include/clutter-1.0/clutter/deprecated/clutter-texture.h:69) [-Wdeprecated-declarations]
make[2]: *** [CMakeFiles/pantheon-greeter.dir/src/Wallpaper.c.o] Error 1
make[1]: *** [CMakeFiles/pantheon-greeter.dir/all] Error 2
make: *** [all] Error 2

codygarver@cubie:~/greeter/build$ valac --version
Vala 0.16.1