Merge lp:~elementary-apps/granite/saved-state into lp:~elementary-pantheon/granite/granite
Status: | Rejected |
---|---|
Rejected by: | xapantu |
Proposed branch: | lp:~elementary-apps/granite/saved-state |
Merge into: | lp:~elementary-pantheon/granite/granite |
Diff against target: |
250 lines (+229/-1) 2 files modified
lib/CMakeLists.txt (+2/-1) lib/Services/SavedState.vala (+227/-0) |
To merge this branch: | bzr merge lp:~elementary-apps/granite/saved-state |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
xapantu (community) | Disapprove | ||
Rico Tzschichholz | Needs Information | ||
Review via email: mp+232092@code.launchpad.net |
Description of the change
The current system of the saved-state logic is currently done by each app on their own, and the result is either half-implemented, wrong-implemented, not-implemented or twice-implemented processes for syncing the window-state to the gsettings-backend.
This branch adds a simple API extension to Granite that allows to sync a specified window to a single specified gsettings-key.
To test this branch i implemented a useage of this API in Terminal: https:/
Unmerged revisions
- 783. By Raphael Isemann
-
Added support for maximized_
fullscreen and fixed the saving of the window-state to the dconf-base (before we used the wrong method with the same name from Gtk.Widget instead of Gdk.Window). Also moved the methods to the upper part of the class and expanded documentation a bit. - 782. By Raphael Isemann
-
Fixed saved-state parsing and fixed setting the window-size
- 781. By Raphael Isemann
-
We moved to a single key now as the backend
- 780. By Raphael Isemann
-
Added SavedState class
This is what is suppose to be achieved with the following:
http:// valadoc. org/#!api= gio-2.0/ GLib.Settings. bind valadoc. org/#!api= gio-2.0/ GLib.Settings. bind_with_ mapping valadoc. org/#!api= gio-2.0/ GLib.Settings. bind_writable
http://
http://
Besides that "SavedState" is not really descriptive enough since only Gtk.Windows are supported