Merge lp:~elementary-apps/granite/fix-welcome-style into lp:~elementary-pantheon/granite/granite

Proposed by Danielle Foré
Status: Merged
Approved by: Danielle Foré
Approved revision: 747
Merged at revision: 746
Proposed branch: lp:~elementary-apps/granite/fix-welcome-style
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 58 lines (+6/-13)
1 file modified
lib/Widgets/Welcome.vala (+6/-13)
To merge this branch: bzr merge lp:~elementary-apps/granite/fix-welcome-style
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Robert Roth (community) Approve
Review via email: mp+225424@code.launchpad.net

Commit message

* fix welcome widget text color for dark themes.
* uses h styles from the theme, not utils
* remove content view class

Description of the change

Basically just remove a bunch of styling garbage and let the theme do its job.

* fixes welcome widget text color for dark themes.
* uses h styles from the theme, not utils
* remove content view class

To post a comment you must log in.
747. By Danielle Foré

remove more BS

Revision history for this message
Robert Roth (evfool) wrote :

Looks fine, cleaning up BS is always good.

review: Approve
Revision history for this message
Danielle Foré (danrabbit) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/Widgets/Welcome.vala'
--- lib/Widgets/Welcome.vala 2014-04-08 20:21:10 +0000
+++ lib/Widgets/Welcome.vala 2014-07-03 05:29:08 +0000
@@ -79,23 +79,19 @@
79 // Box properties79 // Box properties
80 content.homogeneous = false;80 content.homogeneous = false;
8181
82 // Add content-view styling
83 get_style_context().add_class (StyleClass.CONTENT_VIEW);
84
85 // Top spacer82 // Top spacer
86 content.pack_start (new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0), true, true, 0);83 content.pack_start (new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0), true, true, 0);
8784
88 // Labels85 // Labels
89 title_label = new Gtk.Label (title_text);86 title_label = new Gtk.Label (title_text);
90 Utils.apply_text_style_to_label (TextStyle.H1, title_label);87 title_label.get_style_context ().add_class ("h1");
9188
92 title_label.set_justify (Gtk.Justification.CENTER);89 title_label.set_justify (Gtk.Justification.CENTER);
93 content.pack_start (title_label, false, true, 0);90 content.pack_start (title_label, false, true, 0);
9491
95 subtitle_label = new Gtk.Label (subtitle_text);92 subtitle_label = new Gtk.Label (subtitle_text);
96 Utils.apply_text_style_to_label (TextStyle.H2, subtitle_label);93 subtitle_label.get_style_context ().add_class ("h2");
9794
98 subtitle_label.sensitive = false;
99 subtitle_label.set_justify (Gtk.Justification.CENTER);95 subtitle_label.set_justify (Gtk.Justification.CENTER);
10096
101 content.pack_start (subtitle_label, false, true, 2);97 content.pack_start (subtitle_label, false, true, 2);
@@ -189,17 +185,15 @@
189 */185 */
190 public int append_with_image (Gtk.Image? image, string option_text, string description_text) {186 public int append_with_image (Gtk.Image? image, string option_text, string description_text) {
191 // Option label187 // Option label
192 var label = new Gtk.Label (Markup.printf_escaped ("<span weight='medium' size='11700'>%s</span>", option_text));188 var label = new Gtk.Label (option_text);
193 label.use_markup = true;189 label.get_style_context ().add_class ("h3");
194 label.halign = Gtk.Align.START;190 label.halign = Gtk.Align.START;
195 label.valign = Gtk.Align.CENTER;191 label.valign = Gtk.Align.CENTER;
196192
197 // Description label193 // Description label
198 var description = new Gtk.Label (Markup.printf_escaped ("<span weight='medium' size='11400'>%s</span>", description_text));194 var description = new Gtk.Label (description_text);
199 description.use_markup = true;
200 description.halign = Gtk.Align.START;195 description.halign = Gtk.Align.START;
201 description.valign = Gtk.Align.CENTER;196 description.valign = Gtk.Align.CENTER;
202 description.sensitive = false;
203197
204 // Button198 // Button
205 var button = new Gtk.Button ();199 var button = new Gtk.Button ();
@@ -237,5 +231,4 @@
237231
238 return this.children.index (button);232 return this.children.index (button);
239 }233 }
240}234}
241
242\ No newline at end of file235\ No newline at end of file

Subscribers

People subscribed via source and target branches