Merge lp:~elementary-apps/granite/fix-welcome-style into lp:~elementary-pantheon/granite/granite

Proposed by Danielle Foré
Status: Merged
Approved by: Danielle Foré
Approved revision: 747
Merged at revision: 746
Proposed branch: lp:~elementary-apps/granite/fix-welcome-style
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 58 lines (+6/-13)
1 file modified
lib/Widgets/Welcome.vala (+6/-13)
To merge this branch: bzr merge lp:~elementary-apps/granite/fix-welcome-style
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Robert Roth (community) Approve
Review via email: mp+225424@code.launchpad.net

Commit message

* fix welcome widget text color for dark themes.
* uses h styles from the theme, not utils
* remove content view class

Description of the change

Basically just remove a bunch of styling garbage and let the theme do its job.

* fixes welcome widget text color for dark themes.
* uses h styles from the theme, not utils
* remove content view class

To post a comment you must log in.
747. By Danielle Foré

remove more BS

Revision history for this message
Robert Roth (evfool) wrote :

Looks fine, cleaning up BS is always good.

review: Approve
Revision history for this message
Danielle Foré (danrabbit) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/Welcome.vala'
2--- lib/Widgets/Welcome.vala 2014-04-08 20:21:10 +0000
3+++ lib/Widgets/Welcome.vala 2014-07-03 05:29:08 +0000
4@@ -79,23 +79,19 @@
5 // Box properties
6 content.homogeneous = false;
7
8- // Add content-view styling
9- get_style_context().add_class (StyleClass.CONTENT_VIEW);
10-
11 // Top spacer
12 content.pack_start (new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0), true, true, 0);
13
14 // Labels
15 title_label = new Gtk.Label (title_text);
16- Utils.apply_text_style_to_label (TextStyle.H1, title_label);
17+ title_label.get_style_context ().add_class ("h1");
18
19 title_label.set_justify (Gtk.Justification.CENTER);
20 content.pack_start (title_label, false, true, 0);
21
22 subtitle_label = new Gtk.Label (subtitle_text);
23- Utils.apply_text_style_to_label (TextStyle.H2, subtitle_label);
24+ subtitle_label.get_style_context ().add_class ("h2");
25
26- subtitle_label.sensitive = false;
27 subtitle_label.set_justify (Gtk.Justification.CENTER);
28
29 content.pack_start (subtitle_label, false, true, 2);
30@@ -189,17 +185,15 @@
31 */
32 public int append_with_image (Gtk.Image? image, string option_text, string description_text) {
33 // Option label
34- var label = new Gtk.Label (Markup.printf_escaped ("<span weight='medium' size='11700'>%s</span>", option_text));
35- label.use_markup = true;
36+ var label = new Gtk.Label (option_text);
37+ label.get_style_context ().add_class ("h3");
38 label.halign = Gtk.Align.START;
39 label.valign = Gtk.Align.CENTER;
40
41 // Description label
42- var description = new Gtk.Label (Markup.printf_escaped ("<span weight='medium' size='11400'>%s</span>", description_text));
43- description.use_markup = true;
44+ var description = new Gtk.Label (description_text);
45 description.halign = Gtk.Align.START;
46 description.valign = Gtk.Align.CENTER;
47- description.sensitive = false;
48
49 // Button
50 var button = new Gtk.Button ();
51@@ -237,5 +231,4 @@
52
53 return this.children.index (button);
54 }
55-}
56-
57+}
58\ No newline at end of file

Subscribers

People subscribed via source and target branches