Code review comment for lp:~elbati/sale-wkfl/adding_sale_delivery_term_7

On sam. 16 févr. 2013 19:13:19 CET, Lorenzo Battistini - Agile BG -
Domsense wrote:
> On 02/14/2013 10:32 AM, Alexandre Fayolle - camptocamp wrote:
>> Review: Needs Fixing code review, no test
>>
>> When porting a module to V7, please:
>>
>> * update __openerp__.py to use 'data' instead of 'init_xml' and 'update_xml', and 'demo' instead of 'demo_xml'
>> * update you python code to inherit from orm.Model (resp orm.TransientModel) rather than osv.osv (resp. osv.osv_memory)
>> * update you python code tonot instantiate the model class
>
> Hello Alexandre, thanks for suggestions.
> I can't find any standard addon that uses orm.Model, rather osv.Model.
> Did you mean osv.Model?
>

I mean orm.Model, because the Model class is defined in osv/orm.py and
only import from there in osv/osv.py. See
https://code.launchpad.net/~camptocamp/openobject-server/trunk-proposed-cleanups/+merge/102833/comments/269356
for the long version.

Now if you really prefer osv.Model, I won't argue.

--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com