Merge lp:~elbati/purchase-wkfl/fix-purchase_delivery_term-osv into lp:~purchase-core-editors/purchase-wkfl/7.0

Proposed by Lorenzo Battistini
Status: Merged
Approved by: Guewen Baconnier @ Camptocamp
Approved revision: 12
Merged at revision: 12
Proposed branch: lp:~elbati/purchase-wkfl/fix-purchase_delivery_term-osv
Merge into: lp:~purchase-core-editors/purchase-wkfl/7.0
Diff against target: 21 lines (+3/-3)
1 file modified
purchase_delivery_term/purchase.py (+3/-3)
To merge this branch: bzr merge lp:~elbati/purchase-wkfl/fix-purchase_delivery_term-osv
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Stefan Rijnhart (Opener) Approve
Review via email: mp+156034@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

LGTM

review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'purchase_delivery_term/purchase.py'
--- purchase_delivery_term/purchase.py 2013-02-20 07:53:01 +0000
+++ purchase_delivery_term/purchase.py 2013-03-28 17:40:27 +0000
@@ -146,14 +146,14 @@
146 group_ids = group_pool.search(cr, uid, [])146 group_ids = group_pool.search(cr, uid, [])
147 for master_line in self.browse(cr, uid, ids):147 for master_line in self.browse(cr, uid, ids):
148 if master_line.order_line_ids:148 if master_line.order_line_ids:
149 raise osv.except_osv(_('Error'),149 raise orm.except_orm(_('Error'),
150 _("Detailed lines generated yet (for master line '%s'). Remove them first") % master_line.name)150 _("Detailed lines generated yet (for master line '%s'). Remove them first") % master_line.name)
151 if len(master_line.delivery_term_id.line_ids) > len(group_ids):151 if len(master_line.delivery_term_id.line_ids) > len(group_ids):
152 raise osv.except_osv(_('Error'),152 raise orm.except_orm(_('Error'),
153 _("Delivery term lines are %d. Order line groups are %d. Please create more groups")153 _("Delivery term lines are %d. Order line groups are %d. Please create more groups")
154 % (len(master_line.delivery_term_id.line_ids), len(group_ids)))154 % (len(master_line.delivery_term_id.line_ids), len(group_ids)))
155 if not master_line.delivery_term_id.is_total_percentage_correct():155 if not master_line.delivery_term_id.is_total_percentage_correct():
156 raise osv.except_osv(_('Error'),156 raise orm.except_orm(_('Error'),
157 _("Total percentage of delivery term %s is not equal to 1") % master_line.delivery_term_id.name)157 _("Total percentage of delivery term %s is not equal to 1") % master_line.delivery_term_id.name)
158 for group_index, term_line in enumerate(master_line.delivery_term_id.line_ids):158 for group_index, term_line in enumerate(master_line.delivery_term_id.line_ids):
159 order_line_vals = self._prepare_order_line(cr, uid, term_line,159 order_line_vals = self._prepare_order_line(cr, uid, term_line,

Subscribers

People subscribed via source and target branches