Code review comment for lp:~elachuni/wsgi-oops/no-more-twisted
Revision history for this message
| Anthony Lenton (elachuni) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> On Tue, Feb 16, 2010 at 4:01 PM, Elliot Murphy wrote:
> <email address hidden> wrote:
> > The code is taken literally from twisted so it should be completely
> backwards compatible, not need new tests or break existing ones.
>
> What does this mean for copyright? Who has copyright on the code that
> was added? Or did you just re-implement this simple function yourself,
> and the way that twisted had done it was the obvious way to write the
> code?
This branch just copied the function over, docstrings, comments and all. The only clear advantage of this way was that it would be real easy to convince people that it doesn't break any tests; we could reimplement it quickly, inline it or rewrite it as a lambda.
Let me know if we'd need to change the code.