Merge lp:~elachuni/ubuntu-webcatalog/distro-searches into lp:ubuntu-webcatalog
Status: | Merged |
---|---|
Approved by: | Anthony Lenton |
Approved revision: | 40 |
Merged at revision: | 41 |
Proposed branch: | lp:~elachuni/ubuntu-webcatalog/distro-searches |
Merge into: | lp:ubuntu-webcatalog |
Diff against target: |
285 lines (+109/-31) 5 files modified
src/webcatalog/models/applications.py (+1/-1) src/webcatalog/templates/webcatalog/search_results.html (+19/-0) src/webcatalog/tests/test_views.py (+67/-24) src/webcatalog/urls.py (+1/-0) src/webcatalog/views.py (+21/-6) |
To merge this branch: | bzr merge lp:~elachuni/ubuntu-webcatalog/distro-searches |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matthew Nuzum (community) | Approve | ||
Review via email: mp+67257@code.launchpad.net |
Commit message
Make searches distro-series specific
Description of the change
Overview
========
Make searches distro-series specific
Details
=======
Until now, search results would include apps for all distroseries, repeated and intermixed. So if an app is available for four different distroseries, you would get it repeated four times in the search results.
While coding the solution different options were considered:
- Showing an app in search results only once, if it's available in any distroseries. This would require a largeish model change to separate an App from an AppInADistroSeries, with many AppInADistroSeries for each App. And you still never know what distroseries an app you see in your search results is available for.
- Leave search results as is, but add a small label next to each app stating which distroseries it's for. This would still result in multiple instances of almost identical apps in your search results.
- Group search results by distroseries. This is what packages.ubuntu.com does, but it doesn't play well with paging results.
- The current solution, that's to have the search limit to a default distroseries, and allow the user to specify a different distroseries easily (using a right navigation bar in this case).
While I was there, I made distroseries show up in a reverse code_name order in our right sidebars, so that Oneiric is always at the top, and older distroseries are shown further down.
Looks good.