Code review comment for lp:~elachuni/txamqp/heartbeat

Revision history for this message
Thomas Herve (therve) wrote :

OK, some last comments:

1) There is a conflict again :). Be careful here, because connectionLost is now defined in trunk, so you want to move your clean code.

2) The heartbeat test class is called TxTests, it should be named HeartbeatTests. The test file doesn't need the ASF license header too.

Thanks, +1!

review: Approve

« Back to merge proposal