Code review comment for lp:~elachuni/txamqp/heartbeat

Revision history for this message
Thomas Herve (therve) wrote :

Thanks a lot for this code Anthony! It's going to be pretty useful. Here are some comments:

[1] There is a small conflict with current trunk.

[2] The connectionLostEvent doesn't seem to be used anywhere, it can probably be removed.

[3] The test is a bit bad: I understand you want to test it live, but a test running for 8 seconds is too long. Also, setTimeout is deprecated.

Thanks!

review: Needs Fixing

« Back to merge proposal