Code review comment for ~eivnaes/ubuntu/+source/ppp:ubuntu/impish

Revision history for this message
Eivind Naess (eivnaes) wrote :

Robie,

While I have your attention here, there's been another annoying feature that breaks network-manager-sstp project. It's the

https://git.launchpad.net/ubuntu/+source/ppp/tree/debian/extra/ip-up.d/0000usepeerdns#n10

`
nm-pptp-service-*|nm-l2tp-service-*|/org/freedesktop/NetworkManager/PPP/*)
`

It should probably say: nm-*-service-* instead of
`
nm-*-service-*|org/freedesktop/NetworkManager/PPP/*)
`

At least it would permit any clone(s) of the network manager <protocol> plugin to bypass this replacement of resolv.conf.

I filed a bug against this
https://bugs.launchpad.net/ubuntu/+source/ppp/+bug/1921398

it's just that I've not been able to reach anyone to help with getting the issue resolved.

« Back to merge proposal