Code review comment for ~eivnaes/ubuntu/+source/ppp:ubuntu/impish

Revision history for this message
Eivind Naess (eivnaes) wrote :

Robie

Thanks for taking a look at this. The patch is slightly different, as a previous patch to debian pppd replaced all internal crypto calls with calls to use openssl crypto functions. I had to manually re-do the upstream patch with that in mind as the MPPE specific functions was moved into mppe.c (see replace-vendored-hash-functions.patch).

(A little error on the unused Makefile.sol2 here, it adds the sha1.o object, but that isn't even been used here -- solaris2 only).

« Back to merge proposal