Code review comment for ~eivnaes/ubuntu/+source/ppp:ubuntu/impish

Hi Robie,

If you want things fixed today, I maybe able to spare a few minutes just let me know what exactly you need. You can also email me back at eivnaes [at] yahoo [dot] com as I receive notifications on my phone w.r.t. email.

I can generally help with testing on Jimmy. Right now the EAP-MSCHAP fix is definitely busted, and also EAP-TLS doesn't work with the MS-SSTP protocol. The former is definitely hitting people as EAP is the default option for Microsoft Windows. I've committed multiple fixes upstream to pppd project, and unfortunately I don't see an release coming up on a short timeline (unless Paul changes his mind).

It is still unclear what you need me to do, so please hit me up and be specific as the time window is very narrow.

Does this patch apply cleanly to Jimmy? I haven't tried