Code review comment for ~eivnaes/ubuntu/+source/ppp:ubuntu/impish

While the patch itself is substantial, the request seems reasonable.

I've reviewed it as much as I could (I'm not familiar with this area of the ppp code) and I didn't see any obvious problems with it. The comments in https://github.com/ppp-project/ppp/issues/258 where particularly helpful in understanding the ins and outs of the patch.

This is a +1 from me, assuming proper testing afterwards from OP.