Code review comment for lp:~eeejay/mago/get_test_dir
Revision history for this message
| Eitan Isaacson (eeejay) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Looking into the code even before the change, I've seen the usage of '|' as a
> separator to specify multiple oracle files. Wouldn't it be better to specify
> multiple <oracle> tags for that purpose?
Yeah, that is probably not pretty. It is a separate issue, though. Just an arbitrary separator I defined. Multiple 'oracle' tags are not possible because the tag names align to key word args, and you can't have two identical key word args.
It is a separate problem, unrelated to this branch. The proper behavior would probably be appending all identical tag's children to a list, and pass that list with the common tag name.