Code review comment for lp:~eeejay/mago/get_test_dir

Revision history for this message
Javier Collado (javier.collado) wrote :

Hello,

The change looks great since it's indeed better to get the path from the the test suite file itself than from the current working directory.

Looking into the code even before the change, I've seen the usage of '|' as a separator to specify multiple oracle files. Wouldn't it be better to specify multiple <oracle> tags for that purpose?

Best regards,
    Javier

> I came to this modification because I needed to run the notify-osd test
> outside of the Mago directory. I think it would be useful for all tests that
> have data they need to refer to.

« Back to merge proposal