Code review comment for lp:~eeejay/mago/dx

Revision history for this message
Javier Collado (javier.collado) wrote :

Hello Eitan,

I took a quick look at your code and run the tests to check if everything worked in my machine. Unfortunately, I had a few of problems:

- setup.py: File has to be updated to include notify-osd and indicator-applet tests.

- notify-osd: Most of the test cases failed because of screenshot differ failure. Looking at the image in the data directory and at the screenshot it seems that notify-osd draws things slightly different depending on the screen resolution, so the comparison isn't successful unless using the same screen resolution as in the original test.

- share-directory: The share directory in my installation starts with /usr/local/share and the expected shared directory starts with /usr/share so I had to change the hardcoded value to /usr/local/share to make it possible to run the tests. Anyway, I guess that the buildout changes once integrated will solve this issue.

Best regards,
    Javier

« Back to merge proposal