Code review comment for lp:~eeejay/mago/dry_run

Revision history for this message
Javier Collado (javier.collado) wrote :

Hello,

DT_PATH seems to be a useful option. Shouldn't be a good idea to add it as command-line option?

Regarding the dry_run option, despite it seems also useful, I'm not completely sure about the implementation because I think that the "dryrun" argument is passed in a deep hierarchy before being used. If I understood correctly, the option has been added just to log the name of the test cases and test suites that would be run. Then, maybe is a better option to separate the discovery part from the running part so that it isn't needed to pass the "dryrun" argument.

I'm just guessing so maybe what I'm saying it's not possible with the current code, but I would be thinking about something like:
# discovery part logs the suites and test cases found
test_suites = discover_test_suites(DT_PATH)
# running part runs the test cases for all test suites
if not dry_run:
    for test_suite in test_suites:
        test_suite.run()

Best regards,
    Javier

review: Needs Information

« Back to merge proposal