Code review comment for lp:~eeejay/mago/blacklist

Revision history for this message
Javier Collado (javier.collado) wrote :

Hello Eitan,

It seems to me that the changes aren't consistent with the previous design. Given that the whitelisting is performed in the discover method, why not doing the same thing for the blacklist?

The idea is that the discovery does all the filtering and the runner doesn't have to worry about those details. Do you agree on this?

Best regards,
    Javier

review: Needs Information

« Back to merge proposal