The indentation for these statements is a bit weird. I think that it
should look like this:
counts = self.bugtask_set.getStatusCountsForProductSeries(
user, self.series)
return [ (BugTaskStatus.items[status_id], count)
for status_id, count in counts]
186 + [bugtask] = bug.bugtasks
I know that the context makes it unlikely that we'll have > 1 bugtask on
the bug at this point, but for safety's (and readability's) sake I'd
prefer this to be:
Hi Edwin,
Couple of minor nitpicks here, but otherwise this is r=me.
60 + def get_counts(self, user): set.getStatusCo untsForProductS eries( .items[ status_ id], count)
61 + counts = self.bugtask_
62 + user, self.series)
63 + return [(BugTaskStatus
64 + for status_id, count in counts]
The indentation for these statements is a bit weird. I think that it
should look like this:
counts = self.bugtask_ set.getStatusCo untsForProductS eries(
(BugTaskStatus .items[ status_ id], count)
user, self.series)
return [
for status_id, count in counts]
186 + [bugtask] = bug.bugtasks
I know that the context makes it unlikely that we'll have > 1 bugtask on
the bug at this point, but for safety's (and readability's) sake I'd
prefer this to be:
bugtask = bug.default_bugtask