Code review comment for lp:~edwin-grubbs/launchpad/bug-664828-teammembership-delete-timeout

Hi Edwin,

The code in this change looks good to me, and the SQL is nicely documented. My first question is, where does the magic number '12' come from as the query count in test_deactivate_member_query_count? I know the test is for performance testing, but that one test and one number don't detail how the query is expected to perform using different data.

On a related note, is there already a test for the case you mentioned to Robert? "The only way to tell if the super teams still have participants via another path is by recursing the membership tree."

Maris