Code review comment for lp:~edwin-grubbs/launchpad/bug-635302-dsp-filebug-oops

Hi Edwin.

This is a very nice refactoring and improvement to the rules.

There is some scary things in xx-distribution-statistics-portlet.txt, but I will ignore them since you it is unclear what the test is really doing. I think the bugs team should consider deleting it.

I believe you and Brad are solving the same PG issues. You may find you conflict with him. I like you refactoring and hope it is preserved.

I do not have any remarks about your code changes. You comments are clear. I do think something is missing though, and you should investigate why I get oopses when I merge your branch into a local branch:

https://bugs.launchpad.dev/debian/+source/mozilla-firefox
* I see a sidebar with links to do bug searches. I do not think this is correct. The links will show bugs that were reported under the assumption that the project did you LP.

https://launchpad.dev/apache
* OOPS
  Line 74, Column 8
  Expression: <PathExpr standard:u'context/@@+get-involved/answers_usage/enumvalue:LAUNCHPAD'>
  ForbiddenAttribute: ('official_malone', <ProjectGroup at 0xfd1b5ac>)<br />

https://launchpad.dev/gnome
* OOPS (same as above)