Code review comment for lp:~edwin-grubbs/launchpad/bug-602385-register-project-from-sourcepackage-page

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

It would be nice to have some tests for get_register_upstream_url() - making sure dashes are converted properly, etc.

get_register_upstream_url() handles the case of source_package.summary being None - when does that situation occur?

Since it's likely that the user doesn't want to create a project for their own page this way, it might be a good idea to enable the "I do not want to maintain this project" checkbox when registering a project this way.

« Back to merge proposal