Code review comment for lp:~edwin-grubbs/launchpad/bug-600876-ubuntupkg-integrity-error

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank for resolving the contradictory rules to return early when the packaging will be identical (a no change op).

I think the test step is weak (70-77). It looks like it is doing two state transitions. I think the test should directly create the package, then verify that the view return without error when the user attempts to create the identical packaging.

    self.packaging_util.createPackaging(
        productseries=productseries, sourcepackagename=sourcepackagename,
        distroseries=distroseries, packaging=Packaging.PRIMARY, self.product.owner)

review: Approve

« Back to merge proposal