Code review comment for lp:~edwin-grubbs/launchpad/bug-590840-getMembershipInformation-timeout

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Great, thanks Edwin. Small note below that you can choose to ignore.

> === modified file 'lib/lp/registry/model/mailinglist.py'
> --- lib/lp/registry/model/mailinglist.py 2010-04-23 15:19:10 +0000
> +++ lib/lp/registry/model/mailinglist.py 2010-06-10 13:10:37 +0000
> @@ -729,20 +726,13 @@
> Person.teamowner != None))
> )
> team_members = store.using(*tables).find(
> - (EmailAddress, MailingList, Person, Team),
> + (Team.name, Person.displayname, EmailAddress.email),
> And(TeamParticipation.teamID.is_in(team_ids),

I only realised that it wasn't part of your change after testing it, but the And expression is not needed here. Up to you (other examples follow too.

review: Approve (code)

« Back to merge proposal