Great, thanks Edwin. Small note below that you can choose to ignore.
> === modified file 'lib/lp/registry/model/mailinglist.py' > --- lib/lp/registry/model/mailinglist.py 2010-04-23 15:19:10 +0000 > +++ lib/lp/registry/model/mailinglist.py 2010-06-10 13:10:37 +0000 > @@ -729,20 +726,13 @@ > Person.teamowner != None)) > ) > team_members = store.using(*tables).find( > - (EmailAddress, MailingList, Person, Team), > + (Team.name, Person.displayname, EmailAddress.email), > And(TeamParticipation.teamID.is_in(team_ids),
I only realised that it wasn't part of your change after testing it, but the And expression is not needed here. Up to you (other examples follow too.
« Back to merge proposal
Great, thanks Edwin. Small note below that you can choose to ignore.
> === modified file 'lib/lp/ registry/ model/mailingli st.py' registry/ model/mailingli st.py 2010-04-23 15:19:10 +0000 registry/ model/mailingli st.py 2010-06-10 13:10:37 +0000 *tables) .find( email), pation. teamID. is_in(team_ ids),
> --- lib/lp/
> +++ lib/lp/
> @@ -729,20 +726,13 @@
> Person.teamowner != None))
> )
> team_members = store.using(
> - (EmailAddress, MailingList, Person, Team),
> + (Team.name, Person.displayname, EmailAddress.
> And(TeamPartici
I only realised that it wasn't part of your change after testing it, but the And expression is not needed here. Up to you (other examples follow too.