Code review comment for lp:~edwin-grubbs/launchpad/bug-525956-unlink-button

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Edwin.

in retrospect, saying no to updating the DSP page would have been better. On the other hand, I and Adi have wanted a mixin as you have created for sometime. I think the pain was worth it, though it was untimely.

I have one question from the diff. What is "irumpy hotter" in lp/registry/browser/tests/packaging-views.txt? This looks like a paste error. I am not aware of a irumpty test distroseries in the test

review: Approve (code + ui)

« Back to merge proposal