Code review comment for lp:~edwin-grubbs/launchpad/bug-498181-addmember-notify-oops

Revision history for this message
Curtis Hovey (sinzui) wrote :

This is a fine compromise betweent he API and Web interfaces. I have one grammatical suggestion.

=== modified file 'lib/canonical/launchpad/mailnotification.py'
--- lib/canonical/launchpad/mailnotification.py 2009-12-05 18:37:28 +0000
+++ lib/canonical/launchpad/mailnotification.py 2010-01-14 01:55:22 +0000
@@ -953,10 +953,13 @@
             'new-member-notification-for-admins.txt')
         subject = '%s joined %s' % (person.name, team.name)
     elif membership.status == proposed:
- if person.isTeam():
+ # In the UI, a user can only propose themself or a team they

grammar: s/themself/himself/

review: Approve (code)

« Back to merge proposal