Code review comment for lp:~edwin-grubbs/launchpad/bug-498181-addmember-notify-oops

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Summary
-------

In the UI, a user can only propose themself or a team they admin as a
member of another team. Some users of launchpadlib, started proposing
other people to keep track of their mentees. When the proposed member's
email addresses are hidden, this would result in an oops, since
addMember() would trigger an event that tries to email all the
admins of the team with the Reply-To header set to the email of
the proposed member. Since the member is being proposed by someone
else in the same way that teams are proposed, the Reply-To
will be set to the reviewer's email address.

Tests
-----

./bin/test -vv -t webservice/xx-person.txt

Demo and Q/A
------------

With launchpadlib, propose a member with hidden email addresses.

« Back to merge proposal