Code review comment for lp:~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part3

Revision history for this message
Aaron Bentley (abentley) wrote :

The documentation is inverted here:

+First invite ubuntu-team to be member of the name20 team.

- >>> browser.open('http://launchpad.dev/~name21/+addmember')
- >>> browser.getControl('New member:').value = 'ubuntu-team'
+ >>> browser = setupBrowser(
+ ... auth='Basic <email address hidden>:test')
+ >>> browser.open('http://launchpad.dev/~ubuntu-team/+addmember')
+ >>> browser.getControl('New member:').value = 'name20'
     >>> browser.getControl('Add Member').click()

(name20 is added to ubuntu-team)

Other than that, this looks okay to land.

review: Approve (code)

« Back to merge proposal