Code review comment for lp:~edwin-grubbs/launchpad/bug-482176-add-team-member-ajax-part1

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Summary
-------

This is the first branch on the way to adding a picker
to add members to a team with a link on its index page.

Salgado started this branch. I did a little bit of cleanup, but
the following things should be done in a followup branch.

 * Add windmill test.
 * Handle adding teams, which will go into a PROPOSED or INVITED status.

Implementation details
----------------------

The picker widget now clears the search term by default when
the SAVE event is processed (when an item is selected from the results).
The picker widget will also add an onclick handler for you.
    lib/canonical/launchpad/javascript/bugs/bugtask-index.js
    lib/canonical/launchpad/javascript/code/codereview.js

The main part of this feature:
    lib/canonical/launchpad/javascript/registry/team.js
    lib/lp/app/templates/base-layout-macros.pt
    lib/lp/registry/browser/configure.zcml
    lib/lp/registry/browser/person.py
    lib/lp/registry/templates/team-index.pt
    lib/lp/registry/browser/tests/test_person_webservice.py
    lib/lp/registry/templates/team-portlet-membership.pt

Change affecting existing tests:
    lib/lp/registry/model/person.py
    lib/lp/registry/model/teammembership.py
    lib/lp/registry/browser/tests/teammembership-views.txt
    lib/lp/registry/doc/teammembership-email-notification.txt
    lib/lp/registry/doc/teammembership.txt

Tests
-----

./bin/test -vv -t 'test_person_webservice|teammembership-views.txt|teammembership-email-notification.txt|/teammembership.txt'

Demo and Q/A
------------

* Open http://launchpad.dev/~guadamen
  * The "Add member" link should be green, click on it to show the picker.
  * When you click on a person in the picker, the progress spinner
    should display where the (+) icon was.
  * Then there should be a green flash where the person is added to the
    "Latest members" list.

« Back to merge proposal