This is the first branch on the way to adding a picker
to add members to a team with a link on its index page.
Salgado started this branch. I did a little bit of cleanup, but
the following things should be done in a followup branch.
* Add windmill test.
* Handle adding teams, which will go into a PROPOSED or INVITED status.
Implementation details
----------------------
The picker widget now clears the search term by default when
the SAVE event is processed (when an item is selected from the results).
The picker widget will also add an onclick handler for you.
lib/canonical/launchpad/javascript/bugs/bugtask-index.js
lib/canonical/launchpad/javascript/code/codereview.js
The main part of this feature:
lib/canonical/launchpad/javascript/registry/team.js
lib/lp/app/templates/base-layout-macros.pt
lib/lp/registry/browser/configure.zcml
lib/lp/registry/browser/person.py
lib/lp/registry/templates/team-index.pt
lib/lp/registry/browser/tests/test_person_webservice.py
lib/lp/registry/templates/team-portlet-membership.pt
* Open http://launchpad.dev/~guadamen
* The "Add member" link should be green, click on it to show the picker.
* When you click on a person in the picker, the progress spinner
should display where the (+) icon was.
* Then there should be a green flash where the person is added to the
"Latest members" list.
Summary
-------
This is the first branch on the way to adding a picker
to add members to a team with a link on its index page.
Salgado started this branch. I did a little bit of cleanup, but
the following things should be done in a followup branch.
* Add windmill test.
* Handle adding teams, which will go into a PROPOSED or INVITED status.
Implementation details ------- ------- -
-------
The picker widget now clears the search term by default when canonical/ launchpad/ javascript/ bugs/bugtask- index.js canonical/ launchpad/ javascript/ code/codereview .js
the SAVE event is processed (when an item is selected from the results).
The picker widget will also add an onclick handler for you.
lib/
lib/
The main part of this feature: canonical/ launchpad/ javascript/ registry/ team.js lp/app/ templates/ base-layout- macros. pt lp/registry/ browser/ configure. zcml lp/registry/ browser/ person. py lp/registry/ templates/ team-index. pt lp/registry/ browser/ tests/test_ person_ webservice. py lp/registry/ templates/ team-portlet- membership. pt
lib/
lib/
lib/
lib/
lib/
lib/
lib/
Change affecting existing tests: lp/registry/ model/person. py lp/registry/ model/teammembe rship.py lp/registry/ browser/ tests/teammembe rship-views. txt lp/registry/ doc/teammembers hip-email- notification. txt lp/registry/ doc/teammembers hip.txt
lib/
lib/
lib/
lib/
lib/
Tests
-----
./bin/test -vv -t 'test_person_ webservice| teammembership- views.txt| teammembership- email-notificat ion.txt| /teammembership .txt'
Demo and Q/A
------------
* Open http:// launchpad. dev/~guadamen
* The "Add member" link should be green, click on it to show the picker.
* When you click on a person in the picker, the progress spinner
should display where the (+) icon was.
* Then there should be a green flash where the person is added to the
"Latest members" list.