Code review comment for lp:~edwin-grubbs/launchpad/bug-446074-blacklist-form

Revision history for this message
Robert Collins (lifeless) wrote :

>> + self.failUnlessEqual(
>> + self.name_blacklist_match("barfoo"),
>> + self.foo_exp.id)
>
> from https://dev.launchpad.net/TestsStyleGuide:
> When asserting for equality use the form assertEqual
> Can you update all these old tests to assertEqual?

This might be nicer still as

self.assertThat('barfoo', IsBlacklisted())

(with a trivial IsBlacklisted matcher).

-Rob

« Back to merge proposal