Code review comment for lp:~edwin-grubbs/launchpad/bug-272343-packaging-views

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Edwin.

I really appreciate your refactoring to remove the obsolete view. There is a conflict with DistroSeriesStatus that you need to fix. Adi renamed it SeriesStatus yesterday.

I have some hesitation about the assert in the doctest. There was a bad test in the past that wrote the assert wrongly and we did not discover it until after users reported errors. There is nothing wrong with your use, but printing the expected items would make it clear what you expected to be in the vocabulary tokens.

review: Approve

« Back to merge proposal