Code review comment for lp:~edwin-grubbs/launchpad/bug-234051-bug-project-info

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Summary
-------

In the "Assigned bugs" portlet (person-portlet-currentfocus.pt), I added
a table to display the badges like other portlets do. I also added an
additional line that lists all the pillars that a given bug affects.

I also removed the $distribution/+allpackages page as decided in bug
196322
.

I removed the italics from the "registered" css class as requested
in bug 465524 to fix the "Latest memberships" portlet.

Here is a screenshot for the UI review.
https://chinstrap.canonical.com/~egrubbs/bugs_with_pillar_info_and_latest_memberships_without_italics.png

Implementation details
----------------------

I converted the bugtask-listing-detailed.pt page into a macro so that
the show_extra_details variable could be passed in.
    lib/lp/bugs/templates/bugtask-macros-listing.pt

Tests
-----

The only test changes that were necessary were to remove some for
the deleted +allpackages page.

Demo and Q/A
------------

* Open http://launchpad.dev/~name16

« Back to merge proposal