Code review comment for lp:~eduramiba/gephi/linkfluence-features

Revision history for this message
Eduardo Ramos (eduramiba) wrote :

Hi,
Right, I enabled language selection to try it and forgot to disable it.
Then, it will be necessary to delete translated bundles for an 0.7 update
before 0.8 (which will have languages), since they were merged to trunk
recently.
Also I still have to update some translations before 0.8.

When I finish my exams next tuesday I will do that, add/change other
linkfluence plugin features like "copy column of selected nodes to
clipboard" and review the API documentation.

Open URL, tagging, and the clipboard thing could be an extra utils plugin I
guess, yes.

Also, the SPI for context menu actions is very similar to nodes/edges
manipulators of data laboratory (I added support for declaring shortcut keys
and submenues, which could be useful for data lab nodes/edges manipulators).
So, with small changes if necessary, some node actions can appear in graph
view and data lab, and I thought I will add the move/copy to workspace
feature to data laboratory once it has support for the submenues.

Thanks,
Eduardo

2011/2/4 Mathieu Bastian <email address hidden>

> Review: Approve
> Great Job Eduardo, that are great useful features and nice API
> improvements.
>
> Some comments:
> - As we plan to do a last 0.7 update very soon, to include the bugfixes, I
> reverted the LanguageAction change, as new languages will be in 0.8 only
> - The OpenURL contect menu item should rather be in a plugin. Please remove
> it from the trunk and create a plugin branch.
> --
>
> https://code.launchpad.net/~eduramiba/gephi/linkfluence-features/+merge/48162<https://code.launchpad.net/%7Eeduramiba/gephi/linkfluence-features/+merge/48162>
> You are the owner of lp:~eduramiba/gephi/linkfluence-features.
>

« Back to merge proposal