Code review comment for lp:~edgar-b-dsouza/acire/snippet_dependency_res_1

Revision history for this message
Ed S (edgar-b-dsouza) wrote :

Jono: sounds good, but I have a couple of questions.

Add GTK label & button - OK, will do that:

Q1. ...but show the Snippetdependencies dialog on click of the button, right? Or do you want all the relevant code from that .py file pulled in to clutter up bin/acire? :-)

Q2. Add them right away and push updated code to the same feature branch? Is that possible without messing up the review process? Or push it to another feature branch and propose that for merge instead? Sorry, still quite a n00b :-)

Re PPA - well, if that's dropped, I'm relieved :-P since it was quite a hurdle anyway.

« Back to merge proposal