Code review comment for lp:~edb/quam-plures/yet_another_image_branch

Revision history for this message
EdB (edb) wrote :

On 3/7/2011 2:42 AM, Yabs wrote:
> Review: Approve
> I assume Kimberlys comment means "approved" so I'll flag it as such as I don't use tiny and have no idea what I should be looking for ;)
>
> ¥
I hope replying by email from a computer that doesn't know my LP info
recognizes this is me...

The thing to look for even ignoring TinyMCE is problems when inserting
an image via file manager. Core is completely different in this
branch. I tried to ensure good testing of all sorts of combinations but
I wouldn't be surprised if I missed something. 3 options (position,
caption, title) with 3 choices each means ... 3 * 3 * 3 total
possibilities? Plus if the image has or doesn't have a caption or title
stored means even more.

Big-ass branch. I really didn't want to be doing those after we went
live, but I can't see any way to break this smaller. (EdB just in case)

« Back to merge proposal