Code review comment for lp:~eday/nova/lp613264

On 03-11-2010 20:44, Eric Day wrote:
> === modified file 'bin/nova-api'
> --- bin/nova-api 2010-11-02 18:28:14 +0000
> +++ bin/nova-api 2010-11-03 19:44:44 +0000
> @@ -38,15 +38,17 @@
>
> FLAGS = flags.FLAGS
> flags.DEFINE_integer('osapi_port', 8774, 'OpenStack API port')
> +flags.DEFINE_string('osapi_host', '0.0.0.0', 'OpenStack API host')
> flags.DEFINE_integer('ec2api_port', 8773, 'EC2 API port')
> +flags.DEFINE_string('ec2api_host', '0.0.0.0', 'EC2 API host')

Perhaps we should add a note about being ipv4-only (not your fault,
eventlet seems to be that way by default anyway (eventlet.listen has a
kwarg defining the address family. It defaults to 2 (AF_INET))).

> === modified file 'nova/objectstore/handler.py'
> --- nova/objectstore/handler.py 2010-10-25 10:21:09 +0000
> +++ nova/objectstore/handler.py 2010-11-03 19:44:44 +0000
> @@ -438,6 +438,7 @@
> # Disabled because of lack of proper introspection in Twisted
> # or possibly different versions of twisted?
> # pylint: disable-msg=E1101
> - objectStoreService = internet.TCPServer(FLAGS.s3_port, factory)
> + objectStoreService = internet.TCPServer(FLAGS.s3_port, factory,
> + interface=FLAGS.s3_host)
> objectStoreService.setServiceParent(application)
> return application

This will effectively make the objectstore listen only on the loopback
device by default and only work on ipv4. Setting interface to '' instead
will make it listen on whatever.

  vote needsfixing

--
Soren Hansen
Ubuntu Developer http://www.ubuntu.com/
OpenStack Developer http://www.openstack.org/