Code review comment for lp:~ed-leafe/nova/powerstate

Revision history for this message
Rick Harris (rconradharris) wrote :

> This isn't a runtime thing; it only comes into play when the extensions are loaded.

Gotcha.

> 124 + def host_power_action(self, context, instance_id=None, host=None,
> 125 + action=None):

The other part that slightly stood out was having host and action default to None. I would think those should be required arguments (?)

Otherwise, looks great, thanks for the fixes, Ed.

review: Approve

« Back to merge proposal