Code review comment for lp:~ed-leafe/nova/powerstate

Revision history for this message
Trey Morris (tr3buchet) wrote :

I'm with soren, reboot isn't really a state, I see it as an action.
Let's say you take action reboot, the host goes in to state "shutdown" until it comes back up and then it's "online" or i guess maybe "enabled" from the looks of it. It doesn't look like we track host state as we do vm states. Unless I'm mistaken hosts are either enabled or not.

I like the idea of specific actions for reboot, shutdown, and start (similar to _set_enabled_status) instead of a single set_powerstate action. It just seems more accurate and more simple.

These are somewhat drastic suggestions though..

I watched you demonstrate this and the code looks alright otherwise.

« Back to merge proposal