Code review comment for lp:~ed-leafe/nova/powerstate
Revision history for this message
| Ed Leafe (ed-leafe) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
> It seems odd to me to think of "reboot" as a state.
Would it help to think of it as a state change? :)
> Also, I think we should aim to add a get_* method for every set_* method, but
> reading back a "shutdown" or "reboot" state sounds really strange. :)
That's probably why dogmatic coding is a bad thing. :)
> Maybe a more RPC-like interface would be in order?
The request was for a RESTful API for managing the hosts for admins. Presumably then tools will be developed around that API. The tools themselves will likely be developed by each company that uses OpenStack for their own needs and deployment details. If this were for an action that would be carried out as part of normal Nova activity, then yes, an RPC interface might be more appropriate, but as this deals with the physical hosts and not the VMs, we went the RESTful API route.