> I find the terminology a little confusing. What is the difference between
> set_power_state and set_host_powerstate?
Ugh, that's from an earlier version of the branch that I merged. There was already some stuff for VMs that used the term 'power_state', so I changed them in the newer version to be explicit that they were concerned with the host's power state. I'll have to clean that up and re-propose for merging.
> Also, if i understand the code correctly, implementing it for libvirt it
> should be as simple as utils.execute("sudo", "shutdown", "-r", "now")
For reboot, yeah, probably. Since I'm not using libvert, though, I left that for others to code and test. :)
> 79 -# vim: tabstop=4 shiftwidth=4 softtabstop=4
> 80 +#: tabstop=4 shiftwidth=4 softtabstop=4
>
> That looks accidental.
It sure wasn't intentional. Fixed.
> I find the terminology a little confusing. What is the difference between powerstate?
> set_power_state and set_host_
Ugh, that's from an earlier version of the branch that I merged. There was already some stuff for VMs that used the term 'power_state', so I changed them in the newer version to be explicit that they were concerned with the host's power state. I'll have to clean that up and re-propose for merging.
> Also, if i understand the code correctly, implementing it for libvirt it "sudo", "shutdown", "-r", "now")
> should be as simple as utils.execute(
For reboot, yeah, probably. Since I'm not using libvert, though, I left that for others to code and test. :)