Code review comment for lp:~ed-leafe/nova/powerstate

Revision history for this message
Vish Ishaya (vishvananda) wrote :

79 -# vim: tabstop=4 shiftwidth=4 softtabstop=4
80 +#: tabstop=4 shiftwidth=4 softtabstop=4

That looks accidental.

I find the terminology a little confusing. What is the difference between set_power_state and set_host_powerstate?
Also, if i understand the code correctly, implementing it for libvirt it should be as simple as utils.execute("sudo", "shutdown", "-r", "now")

review: Needs Information

« Back to merge proposal