Merge lp:~echeverrifm/oemedical/oemedical_gynecology_and_obstetrics into lp:oemedical

Proposed by Federico Manuel Echeverri Choux
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 127
Merged at revision: 127
Proposed branch: lp:~echeverrifm/oemedical/oemedical_gynecology_and_obstetrics
Merge into: lp:oemedical
Diff against target: 218 lines (+29/-60)
5 files modified
oemedical_gynecology_and_obstetrics/__init__.py (+1/-1)
oemedical_gynecology_and_obstetrics/__openerp__.py (+18/-47)
oemedical_gynecology_and_obstetrics/models/__init__.py (+2/-1)
oemedical_gynecology_and_obstetrics/models/oemedical_gynecology_and_obstetrics.py (+7/-10)
oemedical_gynecology_and_obstetrics/views/oemedical_gynecology_and_obstetrics_view.xml (+1/-1)
To merge this branch: bzr merge lp:~echeverrifm/oemedical/oemedical_gynecology_and_obstetrics
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Guewen Baconnier @ Camptocamp Approve
Pedro Manuel Baeza Approve
Review via email: mp+205885@code.launchpad.net

Description of the change

[IMP] Improve oemedical_gynecology_and_obstetrics module (Fix __openerp__.py file, remove comments or description of module, change dependences )
Improve Gynecology and obstetrics module [clean old code of models]

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Seems OK for me, but please put a proper description on each module to know what it its functionality and features.

Regards.

review: Approve
126. By Federico Manuel Echeverri Choux

[IMP] Improve oemedical_gynecology_and_obstetrics [ Improve description of Gynecology and Obstetrics module ]

Revision history for this message
Federico Manuel Echeverri Choux (echeverrifm) wrote :

> Seems OK for me, but please put a proper description on each module to know
> what it its functionality and features.
>
> Regards.

Hello Pedro

I did it.

About OeMedical gynecology and obstetrics
-----------------------------------------

- Ginecology
    - Mestrual History
- Detection
    - Mammography History
- PAP / COLPO
    - PAP History
    - Colposcopy History
- Obstetrics
    - Pregnancy history

Regards

127. By Federico Manuel Echeverri Choux

[IMP] Improve oemedical_gynecology_and_obstetrics [ Improve inherit view of patient ]

Revision history for this message
Federico Manuel Echeverri Choux (echeverrifm) wrote :

Hello Pedro

I find a few problems
- inherit view of patient
- remove menu xml
- security

Could you tell me if it's ok.

Regards

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

On the revision you have pushed, there is only one change on the view. Rest of the explained things are not covered.

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM thanks

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'oemedical_gynecology_and_obstetrics/__init__.py'
--- oemedical_gynecology_and_obstetrics/__init__.py 2014-01-15 10:20:02 +0000
+++ oemedical_gynecology_and_obstetrics/__init__.py 2014-02-13 01:55:45 +0000
@@ -20,7 +20,7 @@
20#20#
21#/#############################################################################21#/#############################################################################
2222
23import models23from . import models
2424
2525
26# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:26# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
2727
=== modified file 'oemedical_gynecology_and_obstetrics/__openerp__.py'
--- oemedical_gynecology_and_obstetrics/__openerp__.py 2014-01-15 10:20:02 +0000
+++ oemedical_gynecology_and_obstetrics/__openerp__.py 2014-02-13 01:55:45 +0000
@@ -34,58 +34,29 @@
34##############################################################################34##############################################################################
35{35{
3636
37 'name': 'OeMedical : Free Health and Hospital Information System',37 'name': 'OeMedical : gynecology and obstetrics',
38 'version': '1.0',38 'version': '1.0',
39 'author': "OeMEdical Team",39 'author': "OeMEdical Team",
40 'category': 'Generic Modules/Others',40 'category': 'Generic Modules/Others',
41 'depends': ['base', 'sale', 'purchase', 'account', 'product'],41 'depends': ['oemedical'],
42 'application': True,42 'application': True,
43 'description': """43 'description': """
4444
45About OeMedical45About OeMedical gynecology and obstetrics
46---------------46-----------------------------------------
4747
48OeMedical is a multi-user, highly scalable, centralized Electronic48- Ginecology
49Medical Record (EMR) and Hospital Information System for openERP.49 - Mestrual History
5050- Detection
51OeMedical provides a free universal Health and Hospital Information System,51 - Mammography History
52so doctors and institutions all over the world,52- PAP / COLPO
53specially in developing countries will benefit from a centralized,53 - PAP History
54high quality, secure and scalable system.54 - Colposcopy History
5555- Obstetrics
56OeMedical at a glance:56 - Pregnancy history
5757
58 * Strong focus in family medicine and Primary Health Care58
59 59
60 * Major interest in Socio-economics (housing conditions, substance abuse,
61 education...)
62
63 * Diseases and Medical procedures standards (like ICD-10 / ICD-10-PCS ...)
64
65 * Patient Genetic and Hereditary risks : Over 4200 genes related to
66 diseases (NCBI / Genecards)
67
68 * Epidemiological and other statistical reports
69
70 * 100% paperless patient examination and history taking
71
72 * Patient Administration
73 (creation, evaluations / consultations, history ... )
74
75 * Doctor Administration
76
77 * Lab Administration
78
79 * Medicine / Drugs information (vademécum)
80
81 * Medical stock and supply chain management
82
83 * Hospital Financial Administration
84
85 * Designed with industry standards in mind
86
87 * Open Source : Licensed under AGPL
88
89""",60""",
90 "website": "http://launchpad.net/oemedical",61 "website": "http://launchpad.net/oemedical",
91 "licence": "AGPL v3",62 "licence": "AGPL v3",
@@ -106,6 +77,6 @@
106 'qweb': [77 'qweb': [
107 ],78 ],
108 "active": False,79 "active": False,
109 "installable": False,80 "installable": True,
110}81}
111# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:82# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
11283
=== modified file 'oemedical_gynecology_and_obstetrics/models/__init__.py'
--- oemedical_gynecology_and_obstetrics/models/__init__.py 2014-01-15 10:20:02 +0000
+++ oemedical_gynecology_and_obstetrics/models/__init__.py 2014-02-13 01:55:45 +0000
@@ -19,7 +19,8 @@
19# along with this program. If not, see <http://www.gnu.org/licenses/>.19# along with this program. If not, see <http://www.gnu.org/licenses/>.
20#20#
21#/#############################################################################21#/#############################################################################
22import oemedical_gynecology_and_obstetrics22
23from . import oemedical_gynecology_and_obstetrics
2324
2425
25# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:26# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
2627
=== modified file 'oemedical_gynecology_and_obstetrics/models/oemedical_gynecology_and_obstetrics.py'
--- oemedical_gynecology_and_obstetrics/models/oemedical_gynecology_and_obstetrics.py 2014-01-15 10:20:02 +0000
+++ oemedical_gynecology_and_obstetrics/models/oemedical_gynecology_and_obstetrics.py 2014-02-13 01:55:45 +0000
@@ -68,7 +68,6 @@
68 ], 'IUGR', sort=False),68 ], 'IUGR', sort=False),
69 }69 }
7070
71PatientPregnancy()
7271
73class PrenatalEvaluation(orm.Model):72class PrenatalEvaluation(orm.Model):
7473
@@ -121,7 +120,6 @@
121 'iugr' : fields.boolean('IUGR', help="Intra Uterine Growth Restriction"),120 'iugr' : fields.boolean('IUGR', help="Intra Uterine Growth Restriction"),
122 }121 }
123122
124PrenatalEvaluation()
125123
126124
127125
@@ -154,7 +152,6 @@
154 'temperature' : fields.float('Temperature'),152 'temperature' : fields.float('Temperature'),
155 }153 }
156154
157PuerperiumMonitor()
158155
159156
160class PerinatalMonitor(orm.Model):157class PerinatalMonitor(orm.Model):
@@ -182,7 +179,7 @@
182 ('t', 'Footling Breech'),179 ('t', 'Footling Breech'),
183 ], 'Fetus Position', select=True),180 ], 'Fetus Position', select=True),
184 }181 }
185PerinatalMonitor()182
186183
187184
188class OemedicalPerinatal(orm.Model):185class OemedicalPerinatal(orm.Model):
@@ -246,7 +243,7 @@
246 'mother_deceased' : fields.boolean('Deceased', help="Mother died in the process"),243 'mother_deceased' : fields.boolean('Deceased', help="Mother died in the process"),
247 'notes' : fields.text('Notes'),244 'notes' : fields.text('Notes'),
248 }245 }
249OemedicalPerinatal()246
250247
251248
252class OeMedicalPatient(orm.Model):249class OeMedicalPatient(orm.Model):
@@ -291,7 +288,7 @@
291 }288 }
292289
293290
294OeMedicalPatient()291
295292
296293
297class PatientMenstrualHistory(orm.Model):294class PatientMenstrualHistory(orm.Model):
@@ -320,7 +317,7 @@
320317
321 }318 }
322319
323PatientMenstrualHistory()320
324321
325322
326class PatientMammographyHistory(orm.Model):323class PatientMammographyHistory(orm.Model):
@@ -339,7 +336,7 @@
339 'comments' : fields.char('Remarks'),336 'comments' : fields.char('Remarks'),
340 }337 }
341338
342PatientMammographyHistory()339
343340
344341
345class PatientPAPHistory(orm.Model):342class PatientPAPHistory(orm.Model):
@@ -362,7 +359,7 @@
362 ], 'result', help="Please check the lab results if the module is installed"),359 ], 'result', help="Please check the lab results if the module is installed"),
363 'comments' : fields.char('Remarks'),360 'comments' : fields.char('Remarks'),
364 }361 }
365PatientPAPHistory()362
366363
367364
368class PatientColposcopyHistory(orm.Model):365class PatientColposcopyHistory(orm.Model):
@@ -381,7 +378,7 @@
381 'comments' : fields.char('Remarks'),378 'comments' : fields.char('Remarks'),
382 }379 }
383380
384PatientColposcopyHistory()381
385382
386383
387# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:384# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
388385
=== modified file 'oemedical_gynecology_and_obstetrics/views/oemedical_gynecology_and_obstetrics_view.xml'
--- oemedical_gynecology_and_obstetrics/views/oemedical_gynecology_and_obstetrics_view.xml 2014-01-15 10:20:02 +0000
+++ oemedical_gynecology_and_obstetrics/views/oemedical_gynecology_and_obstetrics_view.xml 2014-02-13 01:55:45 +0000
@@ -9,7 +9,7 @@
9 <field name="type">form</field>9 <field name="type">form</field>
10 <field name="arch" type="xml">10 <field name="arch" type="xml">
11 <data>11 <data>
12 <xpath expr="//notebook/page[@string='Misc']" position="before">12 <xpath expr="//notebook/page[@string='General Information']" position="after">
13 <page string="Gyneco / Obs" attrs="{'invisible':[('sex','=', 'm')]}" >13 <page string="Gyneco / Obs" attrs="{'invisible':[('sex','=', 'm')]}" >
14 <notebook>14 <notebook>
15 <page string="Gyneco" >15 <page string="Gyneco" >