Merge lp:~echeverrifm/oemedical/oemedical_gynecology_and_obstetrics into lp:oemedical

Proposed by Federico Manuel Echeverri Choux
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 127
Merged at revision: 127
Proposed branch: lp:~echeverrifm/oemedical/oemedical_gynecology_and_obstetrics
Merge into: lp:oemedical
Diff against target: 218 lines (+29/-60)
5 files modified
oemedical_gynecology_and_obstetrics/__init__.py (+1/-1)
oemedical_gynecology_and_obstetrics/__openerp__.py (+18/-47)
oemedical_gynecology_and_obstetrics/models/__init__.py (+2/-1)
oemedical_gynecology_and_obstetrics/models/oemedical_gynecology_and_obstetrics.py (+7/-10)
oemedical_gynecology_and_obstetrics/views/oemedical_gynecology_and_obstetrics_view.xml (+1/-1)
To merge this branch: bzr merge lp:~echeverrifm/oemedical/oemedical_gynecology_and_obstetrics
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Guewen Baconnier @ Camptocamp Approve
Pedro Manuel Baeza Approve
Review via email: mp+205885@code.launchpad.net

Description of the change

[IMP] Improve oemedical_gynecology_and_obstetrics module (Fix __openerp__.py file, remove comments or description of module, change dependences )
Improve Gynecology and obstetrics module [clean old code of models]

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Seems OK for me, but please put a proper description on each module to know what it its functionality and features.

Regards.

review: Approve
126. By Federico Manuel Echeverri Choux

[IMP] Improve oemedical_gynecology_and_obstetrics [ Improve description of Gynecology and Obstetrics module ]

Revision history for this message
Federico Manuel Echeverri Choux (echeverrifm) wrote :

> Seems OK for me, but please put a proper description on each module to know
> what it its functionality and features.
>
> Regards.

Hello Pedro

I did it.

About OeMedical gynecology and obstetrics
-----------------------------------------

- Ginecology
    - Mestrual History
- Detection
    - Mammography History
- PAP / COLPO
    - PAP History
    - Colposcopy History
- Obstetrics
    - Pregnancy history

Regards

127. By Federico Manuel Echeverri Choux

[IMP] Improve oemedical_gynecology_and_obstetrics [ Improve inherit view of patient ]

Revision history for this message
Federico Manuel Echeverri Choux (echeverrifm) wrote :

Hello Pedro

I find a few problems
- inherit view of patient
- remove menu xml
- security

Could you tell me if it's ok.

Regards

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

On the revision you have pushed, there is only one change on the view. Rest of the explained things are not covered.

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM thanks

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'oemedical_gynecology_and_obstetrics/__init__.py'
2--- oemedical_gynecology_and_obstetrics/__init__.py 2014-01-15 10:20:02 +0000
3+++ oemedical_gynecology_and_obstetrics/__init__.py 2014-02-13 01:55:45 +0000
4@@ -20,7 +20,7 @@
5 #
6 #/#############################################################################
7
8-import models
9+from . import models
10
11
12 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
13
14=== modified file 'oemedical_gynecology_and_obstetrics/__openerp__.py'
15--- oemedical_gynecology_and_obstetrics/__openerp__.py 2014-01-15 10:20:02 +0000
16+++ oemedical_gynecology_and_obstetrics/__openerp__.py 2014-02-13 01:55:45 +0000
17@@ -34,58 +34,29 @@
18 ##############################################################################
19 {
20
21- 'name': 'OeMedical : Free Health and Hospital Information System',
22+ 'name': 'OeMedical : gynecology and obstetrics',
23 'version': '1.0',
24 'author': "OeMEdical Team",
25 'category': 'Generic Modules/Others',
26- 'depends': ['base', 'sale', 'purchase', 'account', 'product'],
27+ 'depends': ['oemedical'],
28 'application': True,
29 'description': """
30
31-About OeMedical
32----------------
33-
34-OeMedical is a multi-user, highly scalable, centralized Electronic
35-Medical Record (EMR) and Hospital Information System for openERP.
36-
37-OeMedical provides a free universal Health and Hospital Information System,
38-so doctors and institutions all over the world,
39-specially in developing countries will benefit from a centralized,
40-high quality, secure and scalable system.
41-
42-OeMedical at a glance:
43-
44- * Strong focus in family medicine and Primary Health Care
45-
46- * Major interest in Socio-economics (housing conditions, substance abuse,
47- education...)
48-
49- * Diseases and Medical procedures standards (like ICD-10 / ICD-10-PCS ...)
50-
51- * Patient Genetic and Hereditary risks : Over 4200 genes related to
52- diseases (NCBI / Genecards)
53-
54- * Epidemiological and other statistical reports
55-
56- * 100% paperless patient examination and history taking
57-
58- * Patient Administration
59- (creation, evaluations / consultations, history ... )
60-
61- * Doctor Administration
62-
63- * Lab Administration
64-
65- * Medicine / Drugs information (vademécum)
66-
67- * Medical stock and supply chain management
68-
69- * Hospital Financial Administration
70-
71- * Designed with industry standards in mind
72-
73- * Open Source : Licensed under AGPL
74-
75+About OeMedical gynecology and obstetrics
76+-----------------------------------------
77+
78+- Ginecology
79+ - Mestrual History
80+- Detection
81+ - Mammography History
82+- PAP / COLPO
83+ - PAP History
84+ - Colposcopy History
85+- Obstetrics
86+ - Pregnancy history
87+
88+
89+
90 """,
91 "website": "http://launchpad.net/oemedical",
92 "licence": "AGPL v3",
93@@ -106,6 +77,6 @@
94 'qweb': [
95 ],
96 "active": False,
97- "installable": False,
98+ "installable": True,
99 }
100 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
101
102=== modified file 'oemedical_gynecology_and_obstetrics/models/__init__.py'
103--- oemedical_gynecology_and_obstetrics/models/__init__.py 2014-01-15 10:20:02 +0000
104+++ oemedical_gynecology_and_obstetrics/models/__init__.py 2014-02-13 01:55:45 +0000
105@@ -19,7 +19,8 @@
106 # along with this program. If not, see <http://www.gnu.org/licenses/>.
107 #
108 #/#############################################################################
109-import oemedical_gynecology_and_obstetrics
110+
111+from . import oemedical_gynecology_and_obstetrics
112
113
114 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
115
116=== modified file 'oemedical_gynecology_and_obstetrics/models/oemedical_gynecology_and_obstetrics.py'
117--- oemedical_gynecology_and_obstetrics/models/oemedical_gynecology_and_obstetrics.py 2014-01-15 10:20:02 +0000
118+++ oemedical_gynecology_and_obstetrics/models/oemedical_gynecology_and_obstetrics.py 2014-02-13 01:55:45 +0000
119@@ -68,7 +68,6 @@
120 ], 'IUGR', sort=False),
121 }
122
123-PatientPregnancy()
124
125 class PrenatalEvaluation(orm.Model):
126
127@@ -121,7 +120,6 @@
128 'iugr' : fields.boolean('IUGR', help="Intra Uterine Growth Restriction"),
129 }
130
131-PrenatalEvaluation()
132
133
134
135@@ -154,7 +152,6 @@
136 'temperature' : fields.float('Temperature'),
137 }
138
139-PuerperiumMonitor()
140
141
142 class PerinatalMonitor(orm.Model):
143@@ -182,7 +179,7 @@
144 ('t', 'Footling Breech'),
145 ], 'Fetus Position', select=True),
146 }
147-PerinatalMonitor()
148+
149
150
151 class OemedicalPerinatal(orm.Model):
152@@ -246,7 +243,7 @@
153 'mother_deceased' : fields.boolean('Deceased', help="Mother died in the process"),
154 'notes' : fields.text('Notes'),
155 }
156-OemedicalPerinatal()
157+
158
159
160 class OeMedicalPatient(orm.Model):
161@@ -291,7 +288,7 @@
162 }
163
164
165-OeMedicalPatient()
166+
167
168
169 class PatientMenstrualHistory(orm.Model):
170@@ -320,7 +317,7 @@
171
172 }
173
174-PatientMenstrualHistory()
175+
176
177
178 class PatientMammographyHistory(orm.Model):
179@@ -339,7 +336,7 @@
180 'comments' : fields.char('Remarks'),
181 }
182
183-PatientMammographyHistory()
184+
185
186
187 class PatientPAPHistory(orm.Model):
188@@ -362,7 +359,7 @@
189 ], 'result', help="Please check the lab results if the module is installed"),
190 'comments' : fields.char('Remarks'),
191 }
192-PatientPAPHistory()
193+
194
195
196 class PatientColposcopyHistory(orm.Model):
197@@ -381,7 +378,7 @@
198 'comments' : fields.char('Remarks'),
199 }
200
201-PatientColposcopyHistory()
202+
203
204
205 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
206
207=== modified file 'oemedical_gynecology_and_obstetrics/views/oemedical_gynecology_and_obstetrics_view.xml'
208--- oemedical_gynecology_and_obstetrics/views/oemedical_gynecology_and_obstetrics_view.xml 2014-01-15 10:20:02 +0000
209+++ oemedical_gynecology_and_obstetrics/views/oemedical_gynecology_and_obstetrics_view.xml 2014-02-13 01:55:45 +0000
210@@ -9,7 +9,7 @@
211 <field name="type">form</field>
212 <field name="arch" type="xml">
213 <data>
214- <xpath expr="//notebook/page[@string='Misc']" position="before">
215+ <xpath expr="//notebook/page[@string='General Information']" position="after">
216 <page string="Gyneco / Obs" attrs="{'invisible':[('sex','=', 'm')]}" >
217 <notebook>
218 <page string="Gyneco" >