Code review comment for lp:~dylanmccall/ubuntu/natty/gnome-settings-daemon/fix-748805

From the bug you said "I decided to change our patch for gnome-settings-daemon, since the existing stuff was a little complex and it wouldn't look pretty inside indicator-sound. (I assume the settings daemon patch inherits that complexity from the original overlay, which had a fancy fading effect)".

Note that this complexity in the code exists to make it easily portable to other applications (we copy and paste the exact same code in gnome-power-manager for example. Even though gnome-power-manager uses a different number of icons, we're able to do this because the thresholds were spaced out in a linear fashion). However, this change actually makes virtually all of gsd-osd-notification.{c/h} pretty pointless now, so you could probably strip most of it out. With the spacing between the icon thresholds being completely uneven, it makes it virtually impossible for this code to be portable anymore.