Merge lp:~dylanmccall/ubiquity-slideshow-ubuntu/1499088-change-layout into lp:ubiquity-slideshow-ubuntu
Proposed by
Dylan McCall
Status: | Merged |
---|---|
Approved by: | Mathieu Trudel-Lapierre |
Approved revision: | 720 |
Merged at revision: | 721 |
Proposed branch: | lp:~dylanmccall/ubiquity-slideshow-ubuntu/1499088-change-layout |
Merge into: | lp:ubiquity-slideshow-ubuntu |
Diff against target: |
35 lines (+11/-5) 1 file modified
slideshows/ubuntu/slides/gethelp.html (+11/-5) |
To merge this branch: | bzr merge lp:~dylanmccall/ubiquity-slideshow-ubuntu/1499088-change-layout |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mathieu Trudel-Lapierre | Approve | ||
Gunnar Hjalmarsson | Approve | ||
Review via email: mp+273346@code.launchpad.net |
Description of the change
Fix for bug #1406972 that changes the layout of the last slide to better accommodate its contents. Please remember to update pot files after merging this change. No string changes, but the surrounding markup is a little different :)
To post a comment you must log in.
Would it not be simpler to have a one-off style= which sets the right CSS attributes on that slide, rather than putting each paragraph in its separate div? It would at least make it so that there are no translation changes required.
For instance, I suggest <div class="text"> to become <div class="text" style="font-color: white"> or something appropriate; as taken from whatever CSS properties should actually be applied here. You also wouldn't need to remove "wide" in that case.