Merge lp:~dylanmccall/harvest/658910 into lp:harvest

Proposed by Dylan McCall
Status: Merged
Merged at revision: 269
Proposed branch: lp:~dylanmccall/harvest/658910
Merge into: lp:harvest
Diff against target: 120 lines (+14/-19)
2 files modified
harvest/media/css/style.css (+13/-18)
harvest/templates/index.html (+1/-1)
To merge this branch: bzr merge lp:~dylanmccall/harvest/658910
Reviewer Review Type Date Requested Status
Daniel Holbach Approve
Review via email: mp+38177@code.launchpad.net

Description of the change

Okay, it's all fixed up. Design changes are funny things, so feel free to share opinions as well as point out my technical wrongdoings :)

Screenshots are up at http://people.ubuntu.com/~dylanmccall/harvest/bugs/lp658910/

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Good work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'harvest/media/css/style.css'
--- harvest/media/css/style.css 2010-10-05 15:27:43 +0000
+++ harvest/media/css/style.css 2010-10-12 03:09:44 +0000
@@ -136,11 +136,11 @@
136}136}
137137
138.sectiontitle {138.sectiontitle {
139 margin-bottom:8px;
140 max-width:30em;139 max-width:30em;
141 letter-spacing:-0.1em;140 letter-spacing:-0.1em;
142 font-size:24px;141 font-size:24px;
143 line-height:28px;142 margin-bottom:12px;
143 color:rgb(80,80,80);
144}144}
145145
146#content > .one_column {146#content > .one_column {
@@ -149,10 +149,6 @@
149149
150150
151151
152#content_welcome .sectiontitle {
153 /* de-emphasize these titles for the more complex page */
154 color:rgb(80,80,80);
155}
156152
157#content_welcome > #start {153#content_welcome > #start {
158 display:table-cell;154 display:table-cell;
@@ -195,10 +191,11 @@
195 font-style:italic;191 font-style:italic;
196}192}
197193
198#content_welcome > #faq {194#content_welcome #faq {
199 display:table-cell;195 display:table-cell;
200 width:430px;196 width:430px;
201 min-width:430px;197 min-width:430px;
198 color:rgb(80,80,80);
202}199}
203200
204#faq > div {201#faq > div {
@@ -213,7 +210,6 @@
213#faq .question {210#faq .question {
214 font-weight:bold;211 font-weight:bold;
215 font-style:italic;212 font-style:italic;
216 color:rgb(180,180,180);
217}213}
218214
219215
@@ -288,17 +284,18 @@
288 margin-bottom:4em;284 margin-bottom:4em;
289}285}
290#filters > .filtergroup > .filter-label {286#filters > .filtergroup > .filter-label {
287 /* titles for groups of filters ("Packages" and "Opportunities") */
291 display:block;288 display:block;
292 margin-bottom:.5em;289 margin-bottom:8px;
293 color:rgb(0,0,0);290 letter-spacing:-0.1em;
294 font-size:14px;291 color:rgb(80,80,80);
295 font-weight:bold;292 font-size:16px;
296}293}
297#filters > .filtergroup > .filter-value > ul {294#filters > .filtergroup > .filter-value > ul {
298 margin-left:0px;295 margin-left:0px;
299}296}
300#filters > .filtergroup > .filter-value > ul > li {297#filters > .filtergroup > .filter-value > ul > li {
301 padding-bottom:5px;298 margin-bottom:5px;
302}299}
303300
304#filters > .filtergroup > .filter-value > ul > li a.help {301#filters > .filtergroup > .filter-value > ul > li a.help {
@@ -449,7 +446,7 @@
449446
450.opportunity-list > .opportunity-list-title {447.opportunity-list > .opportunity-list-title {
451 display:block;448 display:block;
452 color:rgb(80, 80, 80);449 color:rgb(80,80,80);
453 font-size:12px;450 font-size:12px;
454 letter-spacing:-0.1em;451 letter-spacing:-0.1em;
455}452}
@@ -524,8 +521,6 @@
524 display:block;521 display:block;
525 width:100%;522 width:100%;
526 max-width:35em;523 max-width:35em;
527 border-left:dashed 1px rgb(180,180,180);
528 padding:0px 5px;
529 font-size:12px;524 font-size:12px;
530 line-height:1em;525 line-height:1em;
531}526}
@@ -534,13 +529,13 @@
534 border:none;529 border:none;
535 border-bottom:1px solid rgb(180,180,180);530 border-bottom:1px solid rgb(180,180,180);
536 531
537 padding:2px 5px 2px 5px;532 padding:2px 5px;
538 background-color:inherit;533 background-color:inherit;
539 color:inherit;534 color:inherit;
540 font:inherit;535 font:inherit;
541}536}
542.opportunity-notes > ul {537.opportunity-notes > ul {
543 margin:0.5em 0;538 margin:10px 5px;
544 max-height:10em;539 max-height:10em;
545}540}
546.opportunity-notes > ul > li {541.opportunity-notes > ul > li {
547542
=== modified file 'harvest/templates/index.html'
--- harvest/templates/index.html 2010-08-31 19:05:02 +0000
+++ harvest/templates/index.html 2010-10-12 03:09:44 +0000
@@ -57,7 +57,7 @@
5757
58 <li>58 <li>
59 <span class="question">{% trans "I found a bug. What do I do?" %}</span>59 <span class="question">{% trans "I found a bug. What do I do?" %}</span>
60 <p>{% blocktrans %}If it's about the UI or the functionality of the site, please file a bug on <a href="http://bugs.launchpad.net/harvest/+filebug">harvest</a> in Launchpad. If it's about some piece of data in Harvest, it's likely a script that fetches it. In that case, please file your bug on <a href="https://bugs.launchpad.net/harvest-data/+filebug">harvest-data</a> instead. The <a href="http://bazaar.launchpad.net/~harvest-dev/harvest/trunk/annotate/head:/HACKING">hacking guide</a> explains more.{% endblocktrans %}</p>60 <p>{% blocktrans %}If it's about the UI or the functionality of the site, please file a bug on <a href="http://bugs.launchpad.net/harvest/+filebug">harvest</a> in Launchpad. If it's about some piece of data in Harvest, it's likely a script that fetches it. In that case, please file your bug on <a href="http://bugs.launchpad.net/harvest-data/+filebug">harvest-data</a> instead. The <a href="http://bazaar.launchpad.net/~harvest-dev/harvest/trunk/annotate/head:/HACKING">hacking guide</a> explains more.{% endblocktrans %}</p>
61 </li>61 </li>
62 </ul>62 </ul>
63 </div>63 </div>

Subscribers

People subscribed via source and target branches

to all changes: